Skip to content

Scala3doc: make skipping documenting a def a CLI setting #10659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

Scala3doc: make skipping documenting a def a CLI setting #10659

merged 1 commit into from
Dec 15, 2020

Conversation

abgruszecki
Copy link
Contributor

No description provided.

@abgruszecki abgruszecki force-pushed the scala3doc/cli-skip-setting branch 2 times, most recently from d95f1a7 to 9538922 Compare December 14, 2020 10:17
@abgruszecki abgruszecki marked this pull request as ready for review December 14, 2020 13:00
@abgruszecki
Copy link
Contributor Author

@romanowski do you think this looks OK? We could add some tests, but we already exercise the new settings to generate Scala3 documentation. Compare:

Second doesn't show any internal or impl packages.

@romanowski romanowski force-pushed the scala3doc/cli-skip-setting branch from 9538922 to 397bc5a Compare December 15, 2020 21:06
@abgruszecki abgruszecki merged commit 14d4d84 into scala:master Dec 15, 2020
@abgruszecki abgruszecki deleted the scala3doc/cli-skip-setting branch December 15, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanowski romanowski romanowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abgruszecki @romanowski